Re: [evolution-patches] Patch for the bug # 309869

[Jeffrey Stedfast <fejj novell com>]

for future reference, you should make the diff of all changed files in 1
single diff file, including the ChangeLog wherever possible. (there are
certain circumstances where it is betetr to split them, but that's
generally only for when the change splits across multiple components -
mail, calendar, addressbook)

On Wed, 2005-07-13 at 15:57 +0530, Antony Vincent Pandian wrote:
> 
>        Hereby i attach the corrected and revised patch with widget
> pointer comparison with its changelog.
> 
> On 7/13/05, Not Zed <notzed ximian com> wrote:
>         
>         
>         i.e. this means:
>         
>                 if (button == hdrs->priv->cc.label)
>                         /* the 'cc' button was pressed */;
>                 etc.
>         
>         I dont know how you thought a different strcmp implementation
>         wasn't
>         just 'comparing strings'.
>         
>         
>         On Wed, 2005-07-13 at 15:32 +0800, Not Zed wrote:
>         > No, when i said pointer comparisons, i meant nothing to do
>         with the 
>         > strings at all.
>         >
>         > i.e. compare the widget pointers.
>         >
>         >
>         > On Wed, 2005-07-13 at 12:28 +0530, Antony Vincent Pandian
>         wrote:
>         > >
>         > >          Here's the patch with no usage of strcmp. i have
>         written a 
>         > > function string_compare() which does pointer comparisons.
>         > >
>         > >          Herby i attach the patch for the Bug # 309869
>         with its
>         > > Changelog and the changelog of my previous patch for the
>         bug # 301922 
>         > >
>         > > On 7/12/05, Not Zed <notzed ximian com> wrote:
>         > >
>         > >
>         > >         Another strange bug.
>         > >
>         > >         I dont think you should be doing any strcmp stuff
>         - for 
>         > >         starters the
>         > >         text might be translated, i dont know where it is
>         > >         translated.  Compare
>         > >         the widget pointers instead.
>         > >
>         > >         On Tue, 2005-07-12 at 17:11 +0530, Antony Vincent
>         Pandian 
>         > >         wrote:
>         > >         >
>         > >         > Hi,
>         > >         >
>         > >         >      I have attached the patch for the bug #
>         309869.
>         > >         >
>         > >         >      This patch changes the focus to the
>         corresponding
>         > >         headers' entry
>         > >         > fields.
>         > >         >
>         > >         >       The gtk_widget_grab_focus() is added in
>         the functions
>         > >         where the
>         > >         > buttons (headers') click event is handled.
>         > >         >
>         > >         > --
>         > >         > S.Antony Vincent Pandian 
>         > >         > _______________________________________________
>         > >         > evolution-patches mailing list
>         > >         > evolution-patches lists ximian com
>         > >         >
>         http://lists.ximian.com/mailman/listinfo/evolution-patches
>         > >
>         > >
>         > >
>         > >
>         > > -- 
>         > > Luv,
>         > > S.Antony Vincent Pandian
>         > > _______________________________________________
>         > > evolution-patches mailing list
>         > > evolution-patches lists ximian com
>         > > http://lists.ximian.com/mailman/listinfo/evolution-patches
>         >
>         > _______________________________________________ 
>         > evolution-patches mailing list
>         > evolution-patches lists ximian com
>         > http://lists.ximian.com/mailman/listinfo/evolution-patches
>         
> 
> 
> 
> -- 
> Luv,
> S.Antony Vincent Pandian
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com