Re: [evolution-patches] Patch for the bug # 309869

[Antony Vincent Pandian <santony gmail com>]

         Here's the patch with
no usage of strcmp. i have written a  function string_compare()
which does pointer comparisons.

         Herby i attach the
patch for the Bug # 309869 with its Changelog and the changelog of my
previous patch for the bug # 301922

On 7/12/05, Not Zed <notzed ximian com> wrote:

Another strange bug.

I dont think you should be doing any strcmp stuff - for starters the
text might be translated, i dont know where it is translated.  Compare
the widget pointers instead.

On Tue, 2005-07-12 at 17:11 +0530, Antony Vincent Pandian wrote:
>
> Hi,
>
>      I have attached the patch for the bug # 309869.
>
>      This patch changes the focus to the corresponding headers' entry
> fields.
>
>       The gtk_widget_grab_focus() is added in the functions where the
> buttons (headers') click event is handled.
>
> --
> S.Antony Vincent Pandian
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

-- 
Luv,
S.Antony Vincent Pandian
--- e-msg-composer-hdrs-bkp.c	2005-07-13 12:21:21.971867152 +0530
+++ e-msg-composer-hdrs.c	2005-07-13 11:56:42.000000000 +0530
@@ -187,10 +187,33 @@ address_button_clicked_cb (GtkButton *bu
 	hdrs = emchas->hdrs;
 	priv = hdrs->priv;
 
+	if(string_compare (button->label_text,"_Cc:")==0)
+		gtk_widget_grab_focus(hdrs->priv->cc.entry);
+	else if(string_compare (button->label_text,"_Bcc:")==0)
+		gtk_widget_grab_focus(hdrs->priv->bcc.entry);
+	else if(string_compare (button->label_text,"_To:")==0)
+		gtk_widget_grab_focus(hdrs->priv->to.entry);
+
 	name_selector_dialog = e_name_selector_peek_dialog (priv->name_selector);
 	gtk_widget_show (GTK_WIDGET (name_selector_dialog));
 }
 
+static int 
+string_compare(const char * button_label_text_existing,const char * button_label_text_check_string)
+{
+	while(*button_label_text_existing)
+	{
+		if(*button_label_text_existing == *button_label_text_check_string)
+		{
+			button_label_text_existing++;
+			button_label_text_check_string++;
+		}
+		else
+			return (-1);
+	}
+	return 0;			
+}
+
 static void
 from_changed (GtkWidget *item, gpointer data)
 {
@@ -516,6 +539,9 @@ post_browser_clicked_cb (GtkButton *butt
 	GtkWidget *dialog;
 	GList *post_items;
 
+	if(string_compare (button->label_text,"_Post To:")==0)
+		gtk_widget_grab_focus(hdrs->priv->post_to.entry);
+	
 	model = mail_component_peek_tree_model (mail_component_peek ());
 	emft = (EMFolderTree *) em_folder_tree_new_with_model (model);
 	em_folder_tree_set_multiselect (emft, TRUE);

Attachment: Changelog_Bug#309869
Description: Binary data

Attachment: Changelog_Bug#301922
Description: Binary data