Re: [evolution-patches] Patches for leaks in evolution

[Not Zed <notzed ximian com>]

thanks, looks good to me.

On Wed, 2005-07-13 at 11:27 +0200, Kjartan Maraas wrote:
> tir, 12,.07.2005 kl. 09.44 +0800, skrev Not Zed:
> > On Fri, 2005-07-08 at 20:43 +0200, Kjartan Maraas wrote:
> > > 
> > > > In normal processing this value gets transferred to the message list
> > > > search pointer, i guess it only leaks if the processing gets
> > > cancelled.
> > > > 
> > > > You should also add a m->search = NULL in regen_list_regened() after
> > > the
> > > > pointer gets transferred to the messagelist to avoid a double-free
> > > or
> > > > worse.
> > > > 
> > > > Should be ok with that + ready to commit.
> > > > 
> > > I tried wrapping my head around that but failed. Could you show me
> > > where
> > > exactly you mean? 
> > 
> >         if (m->ml->search && m->ml->search != m->search)
> >                 g_free (m->ml->search);
> > 	m->ml->search = m->search;
> > 
> > 
> > There ^^
> > 
> > it sets the search directly on the messagelist.  So m->search should
> > just be set to NULL directly after, if it is to be freed in the free()
> > func.
> > 
> Sorry for being slow, I got stuff mixed up here. Attaching a final
> iteration of the patch here.
> 
> Cheers
> Kjartan
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches