Re: [evolution-patches] Patches for leaks in evolution
- From: Not Zed <notzed ximian com>
- To: Kjartan Maraas <kmaraas broadpark no>
- Cc: evolution-patches lists ximian com
- Subject: Re: [evolution-patches] Patches for leaks in evolution
- Date: Thu, 07 Jul 2005 23:35:16 +0800
> > Any chance of changelogs? They all look good to me though, thanks.
> >
> Attaching new version including ChangeLog entries.
Ok thanks.
> Could you take a look at the message-list.c change? That's a new one
> since the previous patch.
Hmm, I think it is not entirely correct.
In normal processing this value gets transferred to the message list
search pointer, i guess it only leaks if the processing gets cancelled.
You should also add a m->search = NULL in regen_list_regened() after the
pointer gets transferred to the messagelist to avoid a double-free or
worse.
Should be ok with that + ready to commit.
Michael
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]