Re: [evolution-patches] Patches for leaks in evolution

[Kjartan Maraas <kmaraas broadpark no>]

tor, 07,.07.2005 kl. 23.35 +0800, skrev Not Zed:
> > > Any chance of changelogs?  They all look good to me though, thanks.
> > > 
> > Attaching new version including ChangeLog entries.
> 
> Ok thanks.
> 
> > Could you take a look at the message-list.c change? That's a new one
> > since the previous patch.
> 
> Hmm, I think it is not entirely correct.
> 
I noticed, and so did glibc's checks for misbehaving memory management.

> In normal processing this value gets transferred to the message list
> search pointer, i guess it only leaks if the processing gets cancelled.
> 
> You should also add a m->search = NULL in regen_list_regened() after the
> pointer gets transferred to the messagelist to avoid a double-free or
> worse.
> 
> Should be ok with that + ready to commit.
> 
I tried wrapping my head around that but failed. Could you show me where
exactly you mean?

Cheers
Kjartan