Anna should probably review the _'s and make sure they are agreeable
with her.
Jeff
On Tue, 2004-11-02 at 17:30 +0800, Not Zed wrote:
>
> As discussed on irc - for want of any significant reason to reject it,
> apart from the below changes, I don't see any reason to refuse this.
> Might want to wait until tomorrow though, incase any on the wrong side
> of the world care to comment.
>
> Thanks,
> Michael
>
> On Tue, 2004-11-02 at 15:14 +0800, Not Zed wrote:
> >
> > Ok re irc i'll have to get back to you on some of the details, a
> > couple of minor issues though.
> >
> > --- em-format-html-display.c 28 Oct 2004 09:25:26 -0000 1.56
> > +++ em-format-html-display.c 2 Nov 2004 06:49:08 -0000
> > @@ -1296,6 +1296,11 @@ efhd_attachment_button(EMFormatHTML *efh
> > button = gtk_button_new();
> > /*GTK_WIDGET_UNSET_FLAGS(button, GTK_CAN_FOCUS);*/
> > gtk_container_add((GtkContainer *)button,
> > gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE));
> > +
> > + AtkObject *a11y = gtk_widget_get_accessible (button);
> > + atk_object_set_name (a11y, _("Attachment Button"));
> > +
> > +
> > g
> >
> > don't declare the variable 'inline', it must be in the declaration
> > section (before any statements), and don't add 2 blank lines, only
> > add one.
> >
> > and p_4.diff, the camel changes - these are not really strictly gtk
> > strings. but i suppose thats all they'll be used for.
>
> --
>
> Michael Zucchi <notzed ximian com>
> "I'm stuck in a reality I can't
> imagine could be real."
> Novell's Evolution and Free
> Software Developer
--
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com - www.novell.com
Attachment:
smime.p7s
Description: S/MIME cryptographic signature