Re: [evolution-patches] Patches for mail related a11y

[Not Zed <notzed ximian com>]

Hi,

I've only had a quick look, but anything like this:

On Tue, 2004-11-02 at 12:24 +0800, Mengjie Yu wrote:
>     -       w = g_object_new(gtk_check_button_get_type(),
>     -                        "label", text,
>     -                        "active", camel_url_get_param(url, name) != NULL,
>     -                        NULL);
>     +       w = gtk_check_button_new_with_mnemonic (text);
>     +       g_object_set_data ((GObject *)w, "active", camel_url_get_param(url, name) != NULL);

Is incorrect.

first you should use g_object_set not g_object_set_data if you want to do that.  But instead, since its already got a list of set values, just do:

    g_object_new(gtk_check_button_get_type(),
                "label", text,
                "use_underline", TRUE,
                ettc.

i.e. just add the "use_underline", TRUE to the list of arguments.

Since that'll require at least one new patch, i'll await that for review.

Cheers,
 Michael

--

Michael Zucchi <notzed ximian com> "I'm stuck in a reality I can't imagine could be real." Novell's Evolution and Free Software Developer