Re: [evolution-patches] Patches for mail related a11y

[Not Zed <notzed ximian com>]

Ok re irc i'll have to get back to you on some of the details, a couple of minor issues though.

--- em-format-html-display.c	28 Oct 2004 09:25:26 -0000	1.56
+++ em-format-html-display.c	2 Nov 2004 06:49:08 -0000
@@ -1296,6 +1296,11 @@ efhd_attachment_button(EMFormatHTML *efh
 	button = gtk_button_new();
 	/*GTK_WIDGET_UNSET_FLAGS(button, GTK_CAN_FOCUS);*/
 	gtk_container_add((GtkContainer *)button, gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE));
+
+	AtkObject *a11y = gtk_widget_get_accessible (button);
+	atk_object_set_name (a11y, _("Attachment Button"));
+
+
 	g

don't declare the variable 'inline', it must be in the declaration section (before any statements), and don't add 2 blank lines, only add one.

and p_4.diff, the camel changes - these are not really strictly gtk strings.  but i suppose thats all they'll be used for.

On Tue, 2004-11-02 at 15:01 +0800, Mengjie Yu wrote:
> Hi, Not Zed
>
> Thanks a lot about your review.
>
> I have edited the code as your proposal, here they are.
>
>
> Regards
> Mengjie Yu
>
> On Tue, 2004-11-02 at 13:58, Not Zed wrote:
> > Hi,
> > 
> > I've only had a quick look, but anything like this:
> > 
> > On Tue, 2004-11-02 at 12:24 +0800, Mengjie Yu wrote:
> > > -       w = g_object_new(gtk_check_button_get_type(),
> > > -                        "label", text,
> > > -                        "active", camel_url_get_param(url, name) !=
> > > NULL,
> > > -                        NULL);
> > > +       w = gtk_check_button_new_with_mnemonic (text);
> > > +       g_object_set_data ((GObject *)w, "active",
> > > camel_url_get_param(url, name) != NULL);
> > 
> > Is incorrect.
> > 
> > first you should use g_object_set not g_object_set_data if you want to
> > do that.  But instead, since its already got a list of set values,
> > just do:
> > 
> >     g_object_new(gtk_check_button_get_type(),
> >                 "label", text,
> >                 "use_underline", TRUE,
> >                 ettc.
> > 
> > i.e. just add the "use_underline", TRUE to the list of arguments.
> > 
> > Since that'll require at least one new patch, i'll await that for
> > review.
> > 
> > Cheers,
> > Michael
> > -- 
> > 
> > Michael Zucchi <notzed ximian com>
> > "I'm stuck in a reality I can't
> > imagine could be real."
> > Novell's Evolution and Free
> > Software Developer

--

Michael Zucchi <notzed ximian com> "I'm stuck in a reality I can't imagine could be real." Novell's Evolution and Free Software Developer