Re: [evolution-patches] A calendar problem on "play sound" reminder

["jack jia sun com" <jack jia sun com>]

Commit to Trunk.

jack
alfred.peng wrote:

> A new patches with ChangeLog
>
> On Mon, 2004-03-22 at 18:06, Rodrigo Moya wrote:
>  
>
> > On Sun, 2004-03-21 at 15:34 +0800, alfred.peng wrote:
> >
> >    
> >
> > > Dear Rodrigo,
> > >   We found a calendar problem on "play sound" reminder. Would you
> > > please help me to check it?
> > >
> > >   You can reproduce the problem following the steps:
> > >    1.Create a  appointment in the calender
> > >    2.Set up a "play sound" reminder without attachment(sound file) for
> > > this appointment.
> > >    3.Wait for the reminder time to come
> > > result:
> > >    a message show up and there is no sound at all.
> > >
> > >    My opinion is:
> > >    Although there is no attachment for the reminder, maybe we should
> > > still get a *BEEP* sound and a message window.
> > >
> > >      
> > looks ok
> >
> > cheers
> >
> >    
> >
> > ------------------------------------------------------------------------
> >
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
> > retrieving revision 1.2201
> > diff -u -r1.2201 ChangeLog
> > --- ChangeLog	19 Mar 2004 17:03:26 -0000	1.2201
> > +++ ChangeLog	22 Mar 2004 10:35:49 -0000
> > @@ -1,3 +1,10 @@
> > +2004-03-22  Alfred Peng <alfred peng sun com>
> > +
> > +	* gui/alarm-notify/alarm-queue.c (audio_notification): If there
> > +	is no attachment for a audio reminder, only a message window
> > +	shows up.
> > +	Get a beep sound even without attachment for audio reminder.
> > +
> > 2004-03-19  JP Rosevear  <jpr ximian com>
> >
> > 	Fixes #55716
> > Index: gui/alarm-notify/alarm-queue.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/calendar/gui/alarm-notify/alarm-queue.c,v
> > retrieving revision 1.60
> > diff -u -r1.60 alarm-queue.c
> > --- gui/alarm-notify/alarm-queue.c	18 Mar 2004 06:38:35 -0000	1.60
> > +++ gui/alarm-notify/alarm-queue.c	22 Mar 2004 10:35:49 -0000
> > @@ -1041,6 +1041,7 @@
> > 	ECalComponent *comp;
> > 	ECalComponentAlarm *alarm;
> > 	icalattach *attach;
> > +	int	flag = 0;
> >
> > 	comp = cqa->alarms->comp;
> > 	qa = lookup_queued_alarm (cqa, alarm_id);
> > @@ -1058,12 +1059,15 @@
> >
> > 		url = icalattach_get_url (attach);
> >
> > -		if (url && *url && g_file_test (url, G_FILE_TEST_EXISTS))
> > +		if (url && *url && g_file_test (url, G_FILE_TEST_EXISTS)) {
> > +			flag = 1;
> > 			gnome_sound_play (url); /* this sucks */
> > -		else
> > -			gdk_beep ();
> > +		}
> > 	}
> >
> > +	if (!flag)
> > +		gdk_beep ();
> > +
> > 	if (attach)
> > 		icalattach_unref (attach);
> >