[evolution-patches] A calendar problem on "play sound" reminder



Dear Rodrigo,
   We found a calendar problem on "play sound" reminder. Would you
please help me to check it?

   You can reproduce the problem following the steps:
    1.Create a  appointment in the calender
    2.Set up a "play sound" reminder without attachment(sound file) for
this appointment.
    3.Wait for the reminder time to come
 result:
    a message show up and there is no sound at all.

    My opinion is:
    Although there is no attachment for the reminder, maybe we should
still get a *BEEP* sound and a message window.

    Thanks a lot.

Best regards.
Alfred Peng
Index: gui/alarm-notify/alarm-queue.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/alarm-notify/alarm-queue.c,v
retrieving revision 1.60
diff -u -r1.60 alarm-queue.c
--- gui/alarm-notify/alarm-queue.c	18 Mar 2004 06:38:35 -0000	1.60
+++ gui/alarm-notify/alarm-queue.c	21 Mar 2004 07:12:40 -0000
@@ -1041,6 +1041,7 @@
 	ECalComponent *comp;
 	ECalComponentAlarm *alarm;
 	icalattach *attach;
+	int	flag = 0;
 
 	comp = cqa->alarms->comp;
 	qa = lookup_queued_alarm (cqa, alarm_id);
@@ -1058,11 +1059,14 @@
 
 		url = icalattach_get_url (attach);
 
-		if (url && *url && g_file_test (url, G_FILE_TEST_EXISTS))
+		if (url && *url && g_file_test (url, G_FILE_TEST_EXISTS)) {
+			flag = 1;
 			gnome_sound_play (url); /* this sucks */
-		else
-			gdk_beep ();
+		}
 	}
+
+	if (!flag)
+		gdk_beep ();
 
 	if (attach)
 		icalattach_unref (attach);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]