Re: [evolution-patches] cancel_component_dialog patch

["alfred.peng" <alfred peng sun com>]

Dear Rodrigo,

Can you give me some opinion on this patch?

Thanks a lot.

Best regards.

Alfred Peng

On Tue, 2004-03-16 at 17:27, Alfred Peng wrote:
> Dear Rodrigo,
>     We found a contradiction in the source code about calendar. Would 
> you please help me to check it?
> 
>     In the source file 
> calendar/gui/dialogs/send-comp.c(send_component_dialog), when we get 
> value "true" from the function "e_cal_get_save_schedules", we return 
> FALSE immediately.
>     But in the source file 
> calendar/gui/dialogs/cancel-comp.c(cancel_component_dialog), the 
> function return TRUE when getting value "true" from the function 
> "e_cal_get_save_schedules".
>     Maybe we should change the code to make them consistent?
> 
>     Thanks a lot.
> 
> Best Regards
> Alfred Peng
> 
> ______________________________________________________________________
> Index: evolution/calendar/gui/dialogs/cancel-comp.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/cancel-comp.c,v
> retrieving revision 1.11
> diff -u -r1.11 cancel-comp.c
> --- evolution/calendar/gui/dialogs/cancel-comp.c	12 Jan 2004 21:19:09 -0000	1.11
> +++ evolution/calendar/gui/dialogs/cancel-comp.c	16 Mar 2004 09:07:29 -0000
> @@ -47,7 +47,7 @@
>  	gint response;
>  
>  	if (deleting && e_cal_get_save_schedules (client))
> -		return TRUE;
> +		return FALSE;
>  
>  	vtype = e_cal_component_get_vtype (comp);
>