Re: [evolution-patches] Bug 21974: Make editor component configurable

[Jason Hildebrand <jason peaceworks ca>]

On Thu, 2004-01-08 at 17:00, Jeffrey Stedfast wrote:
> > Instead of hardcoding that Vim needs the escape key, we check for
> the
> > "EditorNeedsEscape" property in the editor.

> sounds like a good property name :-)

*grin*  No use beating around the bush. :-)

> oops, found a bug:

> +       /* if any error occurs reading the editor key, fallback to
> GtkHTML */
> +       if (err) {
> +               composer->editor_oafiid =
> GNOME_GTKHTML_EDITOR_CONTROL_ID;
> +               g_error_free (err);
> +       }

> I think you meant to g_strdup (GNOME_GTKHTML_EDITOR_CONTROL_ID);

Good eye - thanks!  It's fixed in the patch below.

> other than that, I'm satisfied with this patch. I would, however,
> like
> to hear what Larry Ewing's and Michael Zucchi's opinions about it.

Alright.

> Assuming they say Go and as soon as we get a (C) assignment (or do we
> already have one?), I think it can be committed.

I sent in the form in early December in anticipation of finally getting
around to submitting this patch, so you should have it on file.

peace,
Jason