Re: [evolution-patches] Bug 21974: Make editor component configurable

[Jeffrey Stedfast <fejj ximian com>]

On Thu, 2004-01-08 at 13:27 -0600, Jason Hildebrand wrote:
> On Thu, 2004-01-08 at 12:51, Jeffrey Stedfast wrote:
> 
> Hi Jeffrey,
> 
> Thanks for your feedback.
> 
> > I'm also thinking that the bit about catching esc needs changing. I
> > think it'd be better if it was a property or something on the editor
> > component as in the future they may be other editor components that
> > will
> > require similar behaviour to the gvim editor, yes?
> 
> I struggled with how best to do this without writing icky special cases.  
> I'll try implementing it using a property as you suggest.

ok, sounds good.

> 
> > should default to the GtkHTML editor control if the key is unset
> > (NULL
> > or ""), or at the very least your patch needs to somehow handle that
> > possibility.
> 
> I can handle this, though that will mean that the default editor id will
> occur in places in the source (in the schema file and in the
> e-msg-composer.c) -- is that ok? 

yea, this is fine by me.

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com