Re: [evolution-patches] Bug 21974: Make editor component configurable

[Jeffrey Stedfast <fejj ximian com>]

basically looks ok to me...

I'd prefer char vs gchar, tho...

I'm also thinking that the bit about catching esc needs changing. I
think it'd be better if it was a property or something on the editor
component as in the future they may be other editor components that will
require similar behaviour to the gvim editor, yes?

also, I think that:

+       composer->editor_oafiid = gconf_client_get_string (
+               gconf, "/apps/evolution/mail/composer/editor_oafiid",
NULL);

should default to the GtkHTML editor control if the key is unset (NULL
or ""), or at the very least your patch needs to somehow handle that
possibility.

Jeff

On Thu, 2004-01-08 at 12:31 -0600, Jason Hildebrand wrote:
> Attached is a patch which allows the use of alternate editors.  The composer
> gets the OAFIID of the editor component to be used from a gconf key.  
> 
> Also, if the current editor is Vim, the composer does not catch the 'ESC'
> keypresses as it normally does, because Vim needs this key.
> 
> thanks,
> Jason
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com