Re: [evolution-patches] Bug 21974: Make editor component configurable

[Jeffrey Stedfast <fejj ximian com>]

On Thu, 2004-01-08 at 17:45, Jason Hildebrand wrote:
> Hi Jeffrey,
> 
> Here's an updated patch.
> 
> Instead of hardcoding that Vim needs the escape key, we check for the 
> "EditorNeedsEscape" property in the editor. 

sounds like a good property name :-)

> 
> The composer falls back to using a hardcoded OAFIID for GtkHTML if
> reading the gconf key fails for some reason.  In testing this I found
> that evo crashes when the editor can't be instantiated, so I also fixed
> this crash in mail/em-utils.c.

awesome, sounds great.

> 
> Lastly, I've included the OAFIID in the error messages so that it's clear to
> the user which editor evo is trying to instantiate.

*nod*



oops, found a bug:

+       /* if any error occurs reading the editor key, fallback to
GtkHTML */
+       if (err) {
+               composer->editor_oafiid =
GNOME_GTKHTML_EDITOR_CONTROL_ID;
+               g_error_free (err);
+       }

I think you meant to g_strdup (GNOME_GTKHTML_EDITOR_CONTROL_ID);

:-)

other than that, I'm satisfied with this patch. I would, however, like
to hear what Larry Ewing's and Michael Zucchi's opinions about it.

Assuming they say Go and as soon as we get a (C) assignment (or do we
already have one?), I think it can be committed.

Thanks,

Jeff