Re: [evolution-patches] Re: Various libebook patches



On Wed, 2004-01-07 at 14:33, Dan Winship wrote:
> > > e_book_load_local_addressbook and e_book_get_default_addressbook have
> > > hard-coded paths to the local address books.  At the moment,
> > > get_default_addressbook() even loads the Evo1.4 book.
> >
> > I agree that the default_addressbook call should be removed, but I
> > think the local addressbook call should stay.  It should always load
> > the addressbook that corresponds to On This Computer/Personal.  People
> > shouldn't have to deal with ESource's when all they want is a tool
> > that modifies their personal addressbook.
> 
> Bzzt! My "personal addressbook" at work is an Exchange contacts folder,
> and at home it's an LDAP server. I don't use the local addressbook at
> all. And didn't we say we're going to let the user delete the local
> folders in 2.0?
> 
> If we're going to have default folders, we need to do them for real like
> in 1.4. If we're not, then the user always needs to be able to choose
> what folder to use, and the code always needs to work with ESources, and
> there shouldn't be a "get local addressbook" call, because it will just
> encourage people to write broken code.

I had totally forgotten about the "Default Folders" option in
Evolution...

Keep e_book_get_default_addressbook() and it should return what the user
has set as the Default in Evo. Makes perfect sense!

Ross
-- 
Ross Burton                                 mail: ross burtonini com
                                          jabber: ross burtonini com
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]