Re: [evolution-patches] Re: Various libebook patches

[Dan Winship <danw ximian com>]

> > e_book_load_local_addressbook and e_book_get_default_addressbook have
> > hard-coded paths to the local address books.  At the moment,
> > get_default_addressbook() even loads the Evo1.4 book.
>
> I agree that the default_addressbook call should be removed, but I
> think the local addressbook call should stay.  It should always load
> the addressbook that corresponds to On This Computer/Personal.  People
> shouldn't have to deal with ESource's when all they want is a tool
> that modifies their personal addressbook.

Bzzt! My "personal addressbook" at work is an Exchange contacts folder,
and at home it's an LDAP server. I don't use the local addressbook at
all. And didn't we say we're going to let the user delete the local
folders in 2.0?

If we're going to have default folders, we need to do them for real like
in 1.4. If we're not, then the user always needs to be able to choose
what folder to use, and the code always needs to work with ESources, and
there shouldn't be a "get local addressbook" call, because it will just
encourage people to write broken code.

-- Dan