Re: [evolution-patches] Various fixes for e-shell-importer.c and mail importers

[Frederic Crozat <fcrozat mandrakesoft com>]

Le mardi 24 août 2004 à 09:57 +0200, Frederic Crozat a écrit :
> Le mardi 24 août 2004 à 10:59 +0800, Not Zed a écrit :
> > On Mon, 2004-08-23 at 14:56 -0400, Rodney Dawes wrote: 
> > > GTK+ really shouldn't spout this warning, I think. It's just annoying to
> > > people who ever look at the console output. It doesn't spit out warnings
> > > for other widgets or functions that may possibly be deprecated in the
> > > future, so why should it here?
> > 
> > But since i doubt this will be fixed with any urgency i guess we'll
> > have to make a mess of the code with ifdef's?  I don't really care too
> > much about the patch, it would just be nice not to have to do it.
> > 
> > We could do something at the top of the file like:
> > #if version >= 2.4.0
> > #define gtk_dialog_set_has_separator(x, y)
> > #endif
> > 
> > But really its 6 of one, half a dozen of another, so the patch is fine
> > as is i guess.
> 
> Ok, so should I consider this as "ok to commit" ?
> 
> BTW, I propose to remove the offending code as soon as Evolution
> enforces GTK+ 2.4 (probably with Evo 2.2, I guess..)
> 
> Same question about the other GTK+ 2.4 warnings patch..

Committed (got Not Zed approval on IRC)

-- 
Frederic Crozat <fcrozat mandrakesoft com>
Mandrakesoft