Re: [evolution-patches] Various fixes for e-shell-importer.c and mail importers

[Not Zed <notzed ximian com>]

On Mon, 2004-08-23 at 14:56 -0400, Rodney Dawes wrote:
> GTK+ really shouldn't spout this warning, I think. It's just annoying to
> people who ever look at the console output. It doesn't spit out warnings
> for other widgets or functions that may possibly be deprecated in the
> future, so why should it here?

But since i doubt this will be fixed with any urgency i guess we'll have to make a mess of the code with ifdef's?  I don't really care too much about the patch, it would just be nice not to have to do it.

We could do something at the top of the file like:
#if version >= 2.4.0
#define gtk_dialog_set_has_separator(x, y)
#endif

But really its 6 of one, half a dozen of another, so the patch is fine as is i guess.

It does seem to be an exceedingly harmless call to be spouting warnings.  I know the gtk+ code is generally really awful at backward compatability, but when it can be, it needn't be so anally retarded about enforcing that lack of backward compatability.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer