Re: [evolution-patches] Various fixes for e-shell-importer.c and mail importers

[Not Zed <notzed ximian com>]

On Fri, 2004-08-20 at 19:22 +0200, Frederic Crozat wrote:
> Le ven 20/08/2004 à 19:10, Not Zed a écrit :
> > > -gtk_dialog_set_has_separator shouldn't be used on message dialog with
> > > GTK+ >= 2.4.0 (it causes a warning)
> > 
> > Do we really want to do this?  We still want it to run on  < gtk 2.4.0
> > i presume.
>
> Yes, this is why I used GTK_CHECK_VERSION in the patch..

Yeah but all the #ifdef crap is a real pain in the arse.

Should we just remove it anyway, doesn't it default to off now?

> > It's only a warning, which >99% of users never ever even see.
>
> Well, if you leave such warnings around, when you try to debug the app
> for another problem, you won't it this is a real problem or not (until
> you dig in GTK+ code..). Moreover, it is not friendly when using gdb +
> --g-fatal-warnings :)

If you're using --g-fatal-warnings that's your problem.

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer