Re: [evolution-patches] Various fixes for e-shell-importer.c and mail importers

[Rodney Dawes <dobey novell com>]

GTK+ really shouldn't spout this warning, I think. It's just annoying to
people who ever look at the console output. It doesn't spit out warnings
for other widgets or functions that may possibly be deprecated in the
future, so why should it here?

-- dobey

M��, 2004-08-23 at 09:56 +0200, Frederic Crozat ka shkruar:
> Le lun 23/08/2004 �5:22, Not Zed a �it :
> > On Fri, 2004-08-20 at 19:22 +0200, Frederic Crozat wrote: 
> > > Le ven 20/08/2004 �9:10, Not Zed a �it :
> > > > > -gtk_dialog_set_has_separator shouldn't be used on message dialog with
> > > > > GTK+ >= 2.4.0 (it causes a warning)
> > > > 
> > > > Do we really want to do this?  We still want it to run on  < gtk 2.4.0
> > > > i presume.
> > > 
> > > Yes, this is why I used GTK_CHECK_VERSION in the patch..
> > Yeah but all the #ifdef crap is a real pain in the arse.
> > 
> > Should we just remove it anyway, doesn't it default to off now?
> 
> Only on GTK+ 2.4 and since Evo doesn't yet required 2.4, I had to use
> such #ifdef. When 2.4 will be required, it will be just a matter of
> removing this #ifdef code.
> 
> I've check GTK+ 2.2 code and this code was required to remove separator
> for message dialog (or you had to use GTK_DIALOG_NO_SEPARATOR in the
> constructor but in that case, GTK+ 2.4 also output a warning).
>