On Tue, 2020-01-14 at 14:25 +0100, Krauß, Peter (SCC) via evolution- list wrote:
So basically it boiled down to e_webdav_session_extract_privilege_simple only returning a single privilege and not the whole set which I think was the bug. Maybe the for loop in e_webdav_session_current_user_privilege_set_cb was supposed to deal with this...?
Hi, aha, I see. I understood from RFC 3744 [1] that the <D:provilege> element can contain only single node, not multiple, and the servers I connect to conform to this expectation, but I didn't find any explicit mention of it in the RFC (just briefly searching through it).
I can send you a diff.
That would surely help, at least to know exactly which parts you touched. Was it anything like the attached patch, please? Could you give it a try, please? It works here, but it the unpatched code worked here as well. By the way, having a reference in a form of a bug report filled at [2] is appreciated. Such changes do need references, places where to look for 'what & why' and eventually report regressions with them. Would you mind to file one, please? Thanks and bye, Milan [1] https://tools.ietf.org/html/rfc3744 [2] https://gitlab.gnome.org/GNOME/evolution-data-server/issues/new
Attachment:
eds.patch
Description: Text Data