Re: [Evolution-hackers] https://bugzilla.gnome.org/show_bug.cgi?id=697632

[samarjit Adhikari <samarjit adhikari gmail com>]

Thanks for holding my hands and helping me to move forward.

With regards,

Samarjit

On Mon, Apr 15, 2013 at 2:24 PM, Milan Crha <mcrha redhat com> wrote:

On Mon, 2013-04-15 at 14:14 +0530, samarjit Adhikari wrote:

> That's the confusion I have. So will the good fix be a g_object_ref
> inside "e_mail_reader_get_folder" on folder object? or is it ok to
> delete the unref. In that case I need to delete all unref
> consistently in mail-to-task.

I'm fine with deleting the g_object_unref() calls on folders returned by
e_mail_reader_get_folder() in mail-to-task code which run in the main
thread (like a response to an action), but if the folder is meant to be
passed into a thread, then for thread safety ref the folder before
running the thread and unref it at the end of the thread.

(I'm not much helpful, right?) :)

Definitely do not change e_mail_reader_get_folder(), it should be left
as is.

        Bye,
        Milan

_______________________________________________
evolution-hackers mailing list
evolution-hackers gnome org
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-hackers