Re: [Evolution-hackers] Regarding API breakage and lost test cases

[Tristan Van Berkom <tristanvb openismus com>]

On 10/05/2012 09:00 PM, Matthew Barnes wrote:
> On Tue, 2012-10-02 at 20:35 +0900, Tristan Van Berkom wrote:
> > Ah, this is gold.
> >
> > I'll be able to readjust things with this.
>
> I've added a new section to the migration guide which covers the basics
> of creating a new local address book or calendar:
>
> https://live.gnome.org/Evolution/ESourceMigrationGuide#How_do_I_create_a_new_calendar_or_address_book.3F

Hi,
    Thanks Matthew for updating the migration guide.
There are a couple of minor issues but overall this is working.

  a.) e_source_registry_commit_source_sync() seems not exactly
      very sync. I haven't looked into that in detail but
      surely the registry server needs to block on something else
      before sending the reply.

      Currently I have things working by adding a 20ms g_timeout_add()
      between e_source_registry_commit_source_sync() and the following
      call to e_source_registry_ref_source() (without out the timeout
      I get a 'no such source' type error).

  b.) It might also be worth noting in the guide/docs that all of
      these calls need to be made in the context of a running main loop
      (I was unable to get it working without a mainloop and with
      a basic call to usleep() for the added delay).

      However, the e-source-registry user facing APIs seem to make an
      attempt at doing this internally (i.e. it has it's own thread
      and mainloop presumably intended to handle the dbus messages as
      a convenience to the caller), so... probably just a minor
      detail or bug to fix there...

Best Regards,
          -Tristan