Re: [Evolution-hackers] Sender photo in email display

[Harish Krishnaswamy <kharish novell com>]

Hi Riccardo,

On Tue, 2006-10-03 at 18:46 +0200, Riccardo Lancellotti wrote:
> Hello,
> I have been working on a patch to add the sender photo when the sender
> of the mail is included in the addressbook and (obviously) it has a
> photo.

Great and Thanks. It is always nice to have new contributors :-). 
Welcome to Evolution .

> The code basically works, but requires some love before becoming a patch
> that can make its way into Evolution.
> Before going on with the code polish process I have some doubts that I
> would like to discuss in the mailing list
> 
> 1)The ui is affected by this patch. It is a trivial addition of a photo
> close to where the rupert monkey appears. Does this addition needs to be
> discussed and approved in some board? Is there any need of some control
> to disable this feaure?

Please go through http://www.gnome.org/projects/evolution/patch.shtml
which describes the patch submission process,  coding style guidelines
and copyright assignment procedures.

> 2) a significant portion of the code that retrieves the contact photo is
> similar to the function "em_utils_in_addressbook()" in em-utils.c (that
> includes also a fancy cache function). Is is a good thing to introduce a
> more general "em_utils_addressbook_lookup()" that is used both by my
> code and by a wrapper that mimics the original em_utils_in_addressbook()
> function? How can I speed up an addressbook lookup? Which are the most
> computationally expensive functions in the lookup? What benchmark can I
> run?

Please mail your patch to the evolution-patches list or preferrably,
file a bug report in bugzilla [1]  and attach the patch. You may discuss
with the evolution  hackers on the IRC [1] or in this mailing list about
design aspects, performance trade-offs etc.


> 3) In the EContactPhoto object the type is not reported. I assume that
> all photos are JPEG, but this looks like a strong assumption. It there
> any better guess I can do?
> 
> 4) This is my first attempt in working on Evolution. Is it better to
> just post the patch early even if the code is not very efficient or do I
> need to improve performance/and functionalities on my own and then post
> everything at the end?

If your patch adheres to the Patch guidelines and applies cleanly on the
source tree, feel free to post it - so it can be reviewed and tested by
the community.


Regards,
Harish

[1] Refer to http://www.gnome.org/projects/evolution/ for more
information.