Re: [Evolution-hackers] Thinking about Quicksearch

[Benjamin Kahn <xkahn ximian com>]

Oops.  You're right.  I was using an old file from an old bug.  I've
attached the patch.

As for the problem with Advanced search being way more complex than
having a long list of searches that most people never use, (body does
not contain?  how many people have used that search?) I actually agree.
The whole Quicksearch UI should be looked at.  There are some
recommendations to fix things floating around.  But they won't get into
Evolution 2.2.  Lets fix the problems we can fix right now.


On Fri, 2005-01-21 at 12:42 +0800, Not Zed wrote:
> 
> you can edit them in ${prefix}/share/evolution/x.x/searchtypes.xml
> 
> and remove/add or whatever.  where x.x is the evolution version.
> 
> It isn't way too complex, havign to do an advanced search for any of
> those is much much more complicated.
> 
> 
> On Thu, 2005-01-20 at 18:59 -0500, Daniel Gryniewicz wrote: 
> > On Thu, 2005-01-20 at 18:04 -0500, Benjamin Kahn wrote:
> > > The current quicksearch list is WAY too long and complex.  I'd like to
> > > see this simplified a lot.  I believe the list should be:
> > > 
> > > 
> > >         Sender or subject contains (default)
> > >         Recipients contains
> > >         Message contains
> > >         ----
> > >         Advanced....
> > >         
> > > I've attached a searches.xml file.
> > > 
> > > (Bug: http://bugzilla.ximian.com/show_bug.cgi?id=69122 )
> > > 
> > > 
> > 
> > Well, that helped, but I still have a ton of searches (subject contains,
> > sender does not contain, body contains, etc.) all coming before those
> > three.  Is there a way to get rid of those?  Are they hardcoded
> > somwhere?
> > 
> > Daniel
> > 
> > _______________________________________________
> > evolution-hackers maillist  -  evolution-hackers lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-hackers

Index: mail/searchtypes.xml
===================================================================
RCS file: /cvs/gnome/evolution/mail/searchtypes.xml,v
retrieving revision 1.2
diff -u -b -r1.2 searchtypes.xml
--- mail/searchtypes.xml	12 Nov 2004 07:07:56 -0000	1.2
+++ mail/searchtypes.xml	21 Jan 2005 20:46:15 -0000
@@ -1,5 +1,6 @@
 <?xml version="1.0"?>
 <filterdescription>
+
 <partset>
  <part name="sender">
   <title>Sender</title>
@@ -429,30 +430,12 @@
   <ruleset>
 
     <rule grouping="any" source="demand">
-      <_title>Subject contains</_title>
+      <_title>Subject or Sender contains</_title>
       <partset>
         <part name="subject">
           <value name="subject-type" type="option" value="contains"/>
           <value name="subject" type="string"/>
         </part>
-      </partset>
-      <sources/>
-    </rule>
-
-    <rule grouping="any" source="demand">
-      <_title>Subject does not contain</_title>
-      <partset>
-        <part name="subject">
-          <value name="subject-type" type="option" value="not contains"/>
-          <value name="subject" type="string"/>
-        </part>
-      </partset>
-      <sources/>
-    </rule>
-
-    <rule grouping="any" source="demand">
-      <_title>Sender contains</_title>
-      <partset>
         <part name="sender">
           <value name="sender-type" type="option" value="contains"/>
           <value name="sender" type="string"/>
@@ -461,49 +444,13 @@
       <sources/>
     </rule>
 
+
     <rule grouping="any" source="demand">
       <_title>Recipients contain</_title>
       <partset>
         <part name="to">
           <value name="recipient-type" type="option" value="contains"/>
           <value name="recipient" type="address"/>
-        </part>
-      </partset>
-      <sources/>
-    </rule>
-
-    <rule grouping="any" source="demand">
-      <_title>Body contains</_title>
-      <partset>
-        <part name="body">
-          <value name="body-type" type="option" value="contains"/>
-          <value name="word" type="string"/>
-        </part>
-      </partset>
-      <sources/>
-    </rule>
-
-    <rule grouping="any" source="demand">
-      <_title>Body does not contain</_title>
-      <partset>
-        <part name="body">
-          <value name="body-type" type="option" value="not contains"/>
-          <value name="word" type="string"/>
-        </part>
-      </partset>
-      <sources/>
-    </rule>
-
-    <rule grouping="any" source="demand">
-      <_title>Body or subject contains</_title>
-      <partset>
-        <part name="subject">
-          <value name="subject-type" type="option" value="contains"/>
-          <value name="subject" type="string"/>
-        </part>
-        <part name="body">
-          <value name="body-type" type="option" value="contains"/>
-          <value name="word" type="string"/>
         </part>
       </partset>
       <sources/>