Re: [Evolution-hackers] Oddness in evolution/e-util/e-xml-utils.c

[Harish Krishnaswamy <kharish novell com>]

Yes..appears to be just a typo to me as well..

Please commit.

thanks,
harish
On Mon, 2005-08-01 at 17:06 +0300, Tor Lillqvist wrote:
> The function e_xml_get_child_by_name_by_lang() doesn't use its lang
> parameter (or the new value it fetches for it with setlocale() in case
> it is NULL). Instead it compares stuff to the static string
> "lang". This presumably is a typo and it should use the parameter lang
> instead?
> 
> (No, I don't know what user-visible effect this buglet has.)
> 
> --tml
> 
> Index: e-util/e-xml-utils.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/e-util/e-xml-utils.c,v
> retrieving revision 1.37
> diff -p -u -2 -r1.37 e-xml-utils.c
> --- e-util/e-xml-utils.c	29 Apr 2005 14:35:58 -0000	1.37
> +++ e-util/e-xml-utils.c	1 Aug 2005 14:05:44 -0000
> @@ -93,5 +93,5 @@ e_xml_get_child_by_name_by_lang (const x
>  			if (this_lang == NULL) {
>  				C = child;
> -			} else if (xmlStrcmp(this_lang, "lang") == 0) {
> +			} else if (xmlStrcmp(this_lang, lang) == 0) {
>  				return child;
>  			}
> 
> _______________________________________________
> evolution-hackers maillist  -  evolution-hackers lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-hackers