Re: Intent to reorganise

[Christian Persch <chpe gnome org>]

Hi,

On Thu, 2004-08-12 at 14:21, Peter Harvey wrote:
> Unfortunately there is an issue. Each action has to do something very
> specific, which in the base of bookmark actions is "open *this* bookmark
> in *this* window". We need one action per bookmark, per window.
> 
> > >      2. Replace the bookmarks menu class with a pair of functions which
> > >         are used to generate action-based bookmark menus.
> > 
> > I guess the intent here is to reuse these for popups ? Maybe we should
> > keep the class, just make it more flexible ...
> 
> Yep. I may change that class to be a kind of factory for bookmark
> actions and the bookmark menus (including popups). Basically it would be
> a wrapper around an action group, and functions for building menus.
[...]
> > >      5. Move the bookmarks_tree_changed_cb from the old bookmarks menu
> > >         class into EphyWindow.
> > 
> > This is related to 2 ? I think the menu class autoupdating itself on
> > tree changes is ok ...
> 
> Yes they are are related. If the menu class was removed then someone had
> to receive the bookmarks_tree_changed signal (and EphyWindow was the
> natural choice). If the menu class is kept, then it will autoupdate
> itself and bookmarks_tree_changed_cb will stay out of EphyWindow.

I think the bookmarks menu should continue to have its own class.
The class to generate action-based bookmarks menu could be used by the
bookmarks menu class to generate the menus.
I'm against moving anything bookmarks-related into EphyWindow; the
ultimate goal is to make bookmarks totally independent of the rest of
epiphany.

Regards,
	Christian