Re: Intent to reorganise

[Marco Pesenti Gritti <marco gnome org>]

On Wed, 2004-08-11 at 03:42, Peter Harvey wrote:
> Hello,
> 
> Looking over the bookmarks menu and toolbar code, I am just itching to
> do a cleanup. I know this has been planned (see the Epiphany 1.4 plan)
> and I am wondering if there is anything in progress at the moment. I
> don't really notice anything happening yet in CVS.
> 
> The things I am currently doing/planning are: 
>      1. Using only a single, persistent GtkActionGroup (called
>         "BookmarkActions") per UI manager so that actions are shared
>         between the bookmarks toolbar and bookmarks menu.

I wonder if there would be any issue in making the group global (shared
by all windows). That would probably improve perf which is pretty bad
atm.

>      2. Replace the bookmarks menu class with a pair of functions which
>         are used to generate action-based bookmark menus.

I guess the intent here is to reuse these for popups ? Maybe we should
keep the class, just make it more flexible ...

>      3. Modify the topic action class to use this (which I presume would
>         solve bug #148714).
>      4. Modify the bookmark action and topic action classes to
>         automatically destroy themselves if a bookmark/topic is deleted.

I'm not sure about autodestroy ... I remember Christian was worried
about the perf cost of connecting one signal per bookmark. Maybe the
group could take care of this ?

>      5. Move the bookmarks_tree_changed_cb from the old bookmarks menu
>         class into EphyWindow.

This is related to 2 ? I think the menu class autoupdating itself on
tree changes is ok ...

> The result should be a system which is much cleaner as the code to
> generate all bookmarks menus (popups or otherwise) would become common.
> If I was to develop such a patch would there be any interest in
> accepting it? (Note: this is separate from my other bookmarks work, and
> this patch would leave the user interface mostly unchanged).

I could definately use some help on this. Cleaning up the code and
improving perf of bookmarks menu is one of the higher priority.

I dont fully understand your plans yet, let's keep discussing it ;)

Marco