Re: [Epiphany] Debian Woody Backport compile problem

[Dan Damian <dandamian gmx net>]

Lame patch I sent. This one should be better.

-dan

On Fri, Mar 07, 2003 at 08:17:09PM +0100, Marco Pesenti Gritti wrote:
> On Fri, 2003-03-07 at 13:39, Dan Damian wrote:
> > Well my patch was a quick fix. I wasn't familiar with variadic macros
> > and I just wanted my ephy to compile... Since I had no problems after
> > compilation, I thought it's OK to share it with Sebastian.
> > 
> > By looking at http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html, I
> > understand that when using named arguments ('args...'), you don't have
> > to use __VA_ARGS__. Attached you'll find a patch that should compile
> > without warnings on both gcc 2.95 and 3.2.
> 
> -- 
> Marco Pesenti Gritti <mpeseng@tin.it>
> I get warnings on gcc 3.2.1.
> 
> ephy-autocompletion.c: In function `ephy_autocompletion_set_key':
> ephy-autocompletion.c:217: warning: too few arguments for format
> 
> Any idea ?
> 
> Marco
--- ../../cvs/epiphany/lib/ephy-debug.h	Thu Feb 27 18:26:56 2003
+++ ephy-debug.h	Fri Mar  7 22:02:30 2003
@@ -33,12 +33,12 @@
 #endif
 
 #ifdef DISABLE_LOGGING
-#define LOG(msg, ...)
+#define LOG(msg, args...)
 #else
-#define LOG(msg, ...)						\
+#define LOG(msg, args...)						\
 g_log (G_LOG_DOMAIN, G_LOG_LEVEL_DEBUG,				\
        "[ %s ] " msg,						\
-       __FILE__, ##__VA_ARGS__);
+       __FILE__, ## args);
 #endif
 
 #ifdef DISABLE_PROFILING