Re: [Epiphany] Debian Woody Backport compile problem

[Dan Damian <dandamian gmx net>]

Well my patch was a quick fix. I wasn't familiar with variadic macros
and I just wanted my ephy to compile... Since I had no problems after
compilation, I thought it's OK to share it with Sebastian.

By looking at http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html, I
understand that when using named arguments ('args...'), you don't have
to use __VA_ARGS__. Attached you'll find a patch that should compile
without warnings on both gcc 2.95 and 3.2.

-dan

On Thu, Mar 06, 2003 at 07:35:40PM +0100, Marco Pesenti Gritti wrote:
> On Thu, 2003-03-06 at 17:03, Dan Damian wrote:
> > Hi,
> > 
> > The attached patch should fix your problem. I recompiled edd's debs[1]
> > on woody a couple of weeks ago. Except this small compilation glitch
> > they have been surprinsingly stable for me.
> > 
> 
> gcc 3 doesnt appear to like that :( I wonder if there is a way to do it
> that all compilers like.
> 
> Marco
> 
--- ../../cvs/epiphany/lib/ephy-debug.h	Thu Feb 27 18:26:56 2003
+++ ephy-debug.h	Fri Mar  7 14:33:27 2003
@@ -33,12 +33,12 @@
 #endif
 
 #ifdef DISABLE_LOGGING
-#define LOG(msg, ...)
+#define LOG(msg, args...)
 #else
-#define LOG(msg, ...)						\
+#define LOG(msg, args...)						\
 g_log (G_LOG_DOMAIN, G_LOG_LEVEL_DEBUG,				\
        "[ %s ] " msg,						\
-       __FILE__, ##__VA_ARGS__);
+       __FILE__);
 #endif
 
 #ifdef DISABLE_PROFILING