Re: Small idea to be more positive towards new contributors



On Mon, 2014-09-01 at 20:54 +0200, Sébastien Wilmet wrote:
On Mon, Sep 01, 2014 at 06:00:38PM +0200, Bastien Nocera wrote:
No, "reviewed" is "I'd set this as accepted-commit_now" but I'm not the
maintainer".

Interesting. I was not aware of this meaning. For me "reviewed" was just
"reviewed" in the general sense, and thus was a good alternative for
"rejected" (but I explain in the comment that the approach is not the
good one), and also an alternative to "needs-work".

FWIW:
https://wiki.gnome.org/Projects/GnomeShell/Development/WorkingWithPatches#How_to_review_a_patch


 Anyway a comment
should explain in more details what the reviewer means.

Yeah, that doesn't help that the patch status is negative rather than
positive. Did you read the article I linked to?



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]