Re: Small idea to be more positive towards new contributors

[Sébastien Wilmet <swilmet gnome org>]

Hi,

On Mon, Sep 01, 2014 at 04:36:01PM +0200, Bastien Nocera wrote:
> I think that we should rename the "needs-work" patch status to
> something more positive, and less disheartening for contributors.
>
> "feedback-given" is an alternative which I quite like.
>
> Good idea?

There is already "reviewed" which is more positive and more generic.
"rejected" is even more negative.

"feedback-given" or "reviewed" are almost the same.

The difference between "needs-work", "rejected" or "reviewed" is small.
If you ask the exact definition of each keyword to some developers, I
think you'll get different answers.

I think "reviewed" or "needs-work" can always be used instead of
"rejected". If a patch is "rejected" without requiring more work, it
means that the bug should be closed as WONTFIX.

So maybe only "reviewed" can be kept. The reviewer should anyway write
comments to explain what is wrong.

(yes, WONTFIX is also a bit negative :-)

--
Sébastien