Re: [Ekiga-devel-list] Restoring presence in the SIP code



On 23/09/10 15:09, Julien Puydt wrote:
Le 23/09/2010 14:59, Julien Puydt a écrit :
Le 23/09/2010 14:46, Eugen Dedu a écrit :
On 23/09/10 14:32, Julien Puydt wrote:
Le 23/09/2010 14:22, Eugen Dedu a écrit :
I do not understand: does the code work or not? If not, could you
fix it
(or have you find when the problem is introduced etc.)?

The thing is that opal doesn't seem to call our
OnPresenceInfoReceived/OnDialogInfoReceived methods -- if it were, the
rest looks correct.

And I don't know why opal doesn't call them :-/

Without a patch, OnPresenceInfoReceived (maybe OnDialogInfoReceived too)
is not called. With the patch, it is called (I have tested it). Have you
patched ekiga, as I said in the e-mail attached (in French)?

Uh? I didn't apply any patch... let me check with that :-)

With the patch, we do get the presence information.

But information about "sip:foo ekiga net" comes attached to an uri which
looks like "sip:%3Csip:foo ekiga net>" so indeed the information never
gets related to anything!

My guess is that piece of code in sip-endpoint.cpp (around line 1045) :
SIPURL sip_uri = SIPURL (user);
sip_uri.Sanitise (SIPURL::ExternalURI);
std::string _uri = sip_uri.AsString ();
doesn't do what it is supposed to do!

Is it a bug in opal, or in ekiga, or is it normal to have such an URI?

We have two choices:
- either we fix this (with the patch in the previous e-mail, which is a hack) - or we wait someone :o) to write ekiga code to use the current API, but there is no known time bound limit here

This fix allows to create an unstable release, so that people could be happy (see the new pulse plugin) and we can have feedback on many months of development.

We're getting there, aren't we?

I do not know.

--
Eugen


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]