Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp



Damien Sandras a écrit :
I'm using code like this to ensure sane values:
SetAudioJitterDelay (PMAX (min_val, 20), PMIN (max_val, 1000));

That is wrong : you're protecting the call to SetAudioJitterDelay, not the method itself!

If I have a method which receives an integer which shouldn't be zero, then that method should check for it itself, not each and every use of it!

Snark


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]