Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

[Damien Sandras <dsandras seconix com>]

Le vendredi 11 avril 2008 à 11:26 +0200, Matthias Schneider a écrit :
> Quoting Julien Puydt <jpuydt free fr>:
> 
> > Hi,
> >
> > again, there is a problem with the bridge : it gets something from
> > gmconf, doesn't check before use, and triggers a floating point exception.
> >
> > I'm not sure whether the issue is in ekiga or in opal though :
> > 0x08132c71 in GMManager::set_video_options (this=0x8303238,
> >      options= 0xbfba9fec) at /usr/include/opal/opal/mediafmt.h:877
> > 877	    ) { PWaitAndSignal m(_mutex); MakeUnique(); return m_info !=
> > NULL && m_info->SetOptionInteger(name, value); }
> > (gdb) bt
> > #0  0x08132c71 in GMManager::set_video_options (this=0x8303238,
> >      options= 0xbfba9fec) at /usr/include/opal/opal/mediafmt.h:877
> > #1  0x0814d3d8 in Opal::ConfBridge::on_property_changed (this=0x8319728,
> >      key= 0xbfbaa084, entry=0x8290e60) at
> > endpoints/opal-gmconf-bridge.cpp:127
> >
> > The lines 126 and 127 of the bridge read like :
> >      options.maximum_frame_rate = gm_conf_entry_get_int (entry);
> >      manager.set_video_options (options);
> > if for some reason zero is returned, then we have a crash.
> >
> > Snark
> 
> Sorry Snark,
> this is my fault, I renamed that setting yesterday assuming its only used by the
>  vidinput-gmconf-bridge, where correct checks preventing your issue are being
> done. I can offer to fix it tonight, or you can simply copy and paste the
> section where its being read in the vidinput-gmconf-bridge to the opal bridge.
> 

I think the checks should be done in GMManager::set_video_options too.
It would prevent crashes. (that is what I do).

Btw, I cleaned a lot of things ;-)
-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   NOVACOM         : http://www.novacom.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net