Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp



Le vendredi 11 avril 2008 à 11:56 +0200, Matthias Schneider a écrit :
> Quoting Damien Sandras <dsandras seconix com>:

[...]

> >
> > I think the checks should be done in GMManager::set_video_options too.
> > It would prevent crashes. (that is what I do).

[...]

> I have preferred to do all the checking in the bridge because this code usually
> get rather long and does not add anything helpful to understand the actual code
> in my cores. It will only make the core functions longer, something I would like
> to avoid.

I'm using code like this to ensure sane values:
SetAudioJitterDelay (PMAX (min_val, 20), PMIN (max_val, 1000));

-- 
 _     Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_   NOVACOM         : http://www.novacom.be/
       FOSDEM          : http://www.fosdem.org/
       SIP Phone       : sip:dsandras ekiga net
                       



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]