Re: [Ekiga-devel-list] patches for OPAL for FreeBSD

[Matthias Apitz <guru Sisis de>]

El día Monday, March 31, 2008 a las 07:52:01PM +0200, Matthias Schneider escribió:

> Quoting Damien Sandras <dsandras seconix com>:
> 
> > Hi Matthias,
> >
> > Le vendredi 28 mars 2008 à 07:36 +0100, Matthias Apitz a écrit :
> > > Hi Damien,
> > >
> > > I'm attaching some small patches for OPAL to make it working in FreeBSD;
> > > some pieces are #if defined P_FREEBSD wrapped and should cause no problem
> > > in other systems; concerning the 'configure' changes I don't know how to
> > > provide a common solution (_dlopen & friends are just in libc.so)
> > > because 'configure' and 'plugins/configure' are generated, but in SVN;
> > > please check what you could do so a 'svn update' will not clobber my
> > > changes in my local rep. :-)
> > >
> >
> > I have committed the parts of the patch I thought relevant.
> >
> > I did not commit :
> > * the patch done on configure instead of configure.ac
> > * the patch redefining the path for FreeBSD (/usr/local/lib/ptlib should
> > be added to the Unix path next to /usr/lib/ptlib, but I can not test)
> >
> > Thanks!
> 
> I have a question about the commit in trace.cxx: I found out that there is a
> basename defined in both string.h and libgen.h. However I would prefer to use
> the "string.h-basename". Matthias, could you try a simple
> #include <string.h>
> 
> instead of the
> 
> #ifdef P_FREEBSD
> #include <libgen.h>
> #endif
> 
> ?

the change:

$ diff plugins/video/common/trace.cxx.orig
plugins/video/common/trace.cxx
37a38,39
> #include <string.h>
> 

gives:

gmake[3]: Entering directory
`/usr/home/guru/Ekiga/opal/plugins/video/H.261-vic'
g++ -I../../../include -DWITH_RFC_COMPLIANT_DEFAULTS -I../common -fPIC
-DP_FREEBSD -I/usr/local/include -c ../common/trace.cxx -o obj/trace.o
../common/trace.cxx: In static member function 'static std::ostream&
Trace::Start(const char*, int)':
../common/trace.cxx:62: error: 'basename' was not declared in this scope
gmake[3]: *** [obj/trace.o] Error 1

and the man page on FreeBSD about basename(3C) says:

BASENAME(3)            FreeBSD Library Functions Manual

NAME
     basename -- extract the base portion of a pathname

SYNOPSIS
     #include <libgen.h>

     char *
     basename(const char *path);
	...

diff's for opal/configure.ac and opal/plugins/configure.ac will follow;

	matthias
-- 
Matthias Apitz
Manager Technical Support - OCLC GmbH
Gruenwalder Weg 28g - 82041 Oberhaching - Germany
t +49-89-61308 351 - f +49-89-61308 399 - m +49-170-4527211
e <matthias apitz oclc org> - w http://www.oclc.org/ http://www.UnixArea.de/
b http://gurucubano.blogspot.com/
Don't top-post, read RFC1855 http://www.faqs.org/rfcs/rfc1855.html
A: Because it messes up the order in which people normally read text.
Q: Why is it such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on Usenet and in e-mail?