Re: [PATCH 0/6] Improve the C++ TagLib MP4 handler

[Santtu Lakkala <inz inz fi>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/04/14 11:53, David King wrote:
> Hi Santtu
>
> On 2014-04-10 08:32, Santtu Lakkala <inz inz fi> wrote:
> > This set of patches against the wip/taglib-mp4-cxx branch adds
> > support for cover art and fixes several other fields in a couple
> > of ways.
> >
> > Santtu Lakkala (6): Fix few typos and compilation Add G_DECL
> > boilerplate to picture.h Implement picture support for MP4 Change
> > naming scheme for fields Add missing fields in MP4 saving Use
> > IntPair handling for disc number/total
>
> I do not think that you had updated your checkout of
> wip/taglib-mp4-cxx, as most of the problems were already fixed. I
> rebased your patches on top of the branch, which left number 2 and
> 3 applied. I split off the album artist support into a new patch
> and pushed that to the branch as well. Thanks for that patch
> especially! I wonder if there should be a bug against TagLib to add
> the property convenience accessor (as ALBUMARTIST)?

Aww, crap. I forgot to fetch, and got some somewhat older version of
the branch. Sorry about that. :/

A ALBUMARTIST convenience accessor in TagLib would probably make
sense. Btw, what is the target of easytag, at least Ubuntu (prior to
yet unreleased 14.04) has still 1.8, which doesn't support COPYRIGHT
or COMPOSER either, so if those need to be supported, it needs to be
done via the raw naming itemlists.

- -- 
Santtu



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlNGdBgACgkQX9Rc0+po4p05MgCfWvLOs/JJr+K3kiuyFwPRVZTU
kUIAn2mFsXeJTAuOcg4dlTZvFJHt0rRx
=C+qv
-----END PGP SIGNATURE-----