Re: [PATCH 0/2] GIO wrapper for TagLib



Hi Santtu

On 2014-04-10 11:01, Santtu Lakkala <inz inz fi> wrote:
This is the GIO wrapper implementation from previous big patch, now split
into source and header files. The first patch adds the header and source
files, and the second parts uses the class for MP4 files.

Santtu Lakkala (2):
 Add GIO/TagLib compatibility layer
 Use GIO wrappers in mp4_tag.cc

This looks good! I will review the patches in more detail this evening. Do you think that you can make the error-handling more robust before tomorrow evening? If so, I would like to merge the changes before the release.

Thanks again for the patches.

--
http://amigadave.com/

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]