On 2013-01-09 19:11, Andreas Winkelmann <ml awinkelmann de> wrote:
Am 06.01.2013 17:02, schrieb David King:On 2012-12-30 13:14, Andreas Winkelmann <ml awinkelmann de> wrote:There is (still) a bug in Id3tag_Check_If_Id3lib_Is_Bugged(). gcc warned about an uninitialized var, but at the end there is more ;-) I have tried to fix this as you can see in the commit, but my Eclipse Editor has changed the Garbage-Characters in the Test-Strings to other Garbage-Characters ;-) Maybe you can fix this.I had been working on a slightly different approach to that problem: http://git.gnome.org/browse/easytag/commit/?h=wip/easytag-next&id=225878e4567f2b816840b7d65d888db2ab2c8d48 but that branch (wip/easytag-next) is not quite ready for merging yet.gchar *filename_utf8 = filename_to_display (g_file_get_path (file)); This will never g_free() the Memory for the result of g_file_get_path(). Correct?
Correct, and exactly the reason why that branch is not ready to be merged yet. ;-) Thanks for spotting it nonetheless.
Unfortunately, this caused me to go and read the source of filename_to_display(). :-(
-- http://amigadave.com/
Attachment:
pgpR3uB0V5sRq.pgp
Description: PGP signature