Re: Some modifications...

[Andreas Winkelmann <ml awinkelmann de>]

Hi David.

On 12/30/2012 08:45 AM, David King wrote:
> > - For Amarok I have needed a special MP3 Tag, to separate Compilations
> > from normal Albums. In detail Amarok uses itself "TCMP". With a Value of
> > "0" this is a normal album, with "1" a sampler (Various Artists). If
> > this is unset, Amarok shuffles between this two cases somehow. In ET I
> > have added a Column in the BrowserList and a new TextBox in the Tag
> > Fields and everything else what was needed to handle this Tag.
>
> Likewise, please post the patch and hopefully it can be merged.
In between I have seen the background for this flag was not Amarok, it 
was an iTunes thing. Of course ;-) But probably Amarok adopted it. One 
reference I have found:

http://id3.org/iTunes%20Compilation%20Flag

In my code I have choosen a Text Field for this. Because I was not sure 
what exact values can appear. For my Music Collection I am using the 
values from the Link "0", "1" or unset. If the Text from the Link can be 
taken as Law, maybe a Combo-Box would be nicer. But what if a mp3-file 
arrives from someone else with other values in it...

> > - And Hmm a very minor thing, and I have added an entry in the context
> > Menu in the Tag Fields. A almost One-Click way to remove the complete
> > Text from the selected Field. Without this I had to select the whole
> > text in the line first and then delete it.
>
> Good idea!
>
> > For me these things are helping me.
> > If there is interest I can share this somehow. At the moment I have not
> > yet a public git-repository somewhere.
>
> It would certainly be good to look at your changes. Can you create a 
> git repository on Gitorious or github, or maybe post your patches 
> directly to this mailing list if they are small enough?

I have pushed my repo to github. Link is 
https://github.com/awinkelmann/easytag

Two additional changes,

Rearranging the Tag Fields. It was nicer to see the Album-Name in a full 
row.

There is (still) a bug in Id3tag_Check_If_Id3lib_Is_Bugged(). gcc warned 
about an uninitialized var, but at the end there is more ;-) I have 
tried to fix this as you can see in the commit, but my Eclipse Editor 
has changed the Garbage-Characters in the Test-Strings to other 
Garbage-Characters ;-) Maybe you can fix this.

--
Regards,
Andreas