Re: [Easytag-mailing] Re: EasyTAG 1.99.8 has been released! (Developing GTK 2.4 version)

[Jérôme COUDERC <easytag gmail com>]

Hi Julian,

   Indeed the INSTALL file was updated to recommend to install MPEG4IP.
Your compiltation problem with faad2 is worst than mine on my system, 
but even with a recent package 
(http://heidelberg.freshrpms.net/rpm.html?id=1300), it seems that faad2 
is incomplete : mp4.h contains all the needed prototypes but functions 
aren't present in libmp4v2.so!

The only way for the moment is to compile mpeg4ip...

Here is a patch for EasyTAG 1.99.8 to enable mp4 support with MPEG4IP 
1.2 and not only MPEG4IP 1.3

Regards,
Jerome


Julian Sikorski wrote, the 08.09.2005 09:28 :

> If hat's true either the INSTALL file or easytag should be updated, as
> the file says that everything should work with faad2.
>
>  

--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <easytag gmail com>

diff -ruN easytag-1.99.8.orig/src/mp4_tag.c easytag-1.99.8/src/mp4_tag.c
--- easytag-1.99.8.orig/src/mp4_tag.c	2005-08-30 23:07:21.000000000 +0200
+++ easytag-1.99.8/src/mp4_tag.c	2005-09-07 01:05:52.000000000 +0200
@@ -251,7 +251,8 @@
         MP4SetMetadataName(mp4file, FileTag->title);
     }else
     {
-        MP4DeleteMetadataName(mp4file);
+        //MP4DeleteMetadataName(mp4file); // Not available on mpeg4ip-1.2 (only in 1.3)
+        MP4SetMetadataName(mp4file, "");
     }
     
     /**********
@@ -262,7 +263,8 @@
         MP4SetMetadataArtist(mp4file, FileTag->artist);
     }else
     {
-        MP4DeleteMetadataArtist(mp4file);
+        //MP4DeleteMetadataArtist(mp4file);
+        MP4SetMetadataArtist(mp4file, "");
     }
 
     /*********
@@ -273,7 +275,8 @@
         MP4SetMetadataAlbum(mp4file, FileTag->album);
     }else
     {
-        MP4DeleteMetadataAlbum(mp4file);
+        //MP4DeleteMetadataAlbum(mp4file);
+        MP4SetMetadataAlbum(mp4file, "");
     }
 
     /**********************
@@ -314,7 +317,8 @@
         MP4SetMetadataDisk(mp4file, disk, disktotal);
     }else
     {
-        MP4DeleteMetadataDisk(mp4file);
+        //MP4DeleteMetadataDisk(mp4file);
+        MP4SetMetadataDisk(mp4file, 0, 0);
     }
 
     /********
@@ -325,7 +329,8 @@
         MP4SetMetadataYear(mp4file, FileTag->year);
     }else
     {
-        MP4DeleteMetadataYear(mp4file);
+        //MP4DeleteMetadataYear(mp4file);
+        MP4SetMetadataYear(mp4file, "");
     }
     
     /*************************
@@ -343,18 +348,20 @@
         MP4SetMetadataTrack(mp4file, track, track_total);
     }else
     {
-        MP4DeleteMetadataTrack(mp4file);
+        //MP4DeleteMetadataTrack(mp4file);
+        MP4SetMetadataTrack(mp4file, 0, 0);
     }
 
     /*********
      * Genre *
      *********/
-    if (FileTag->genre && strlen(FileTag->genre)>0 )
+    if (FileTag->genre && g_utf8_strlen(FileTag->genre, -1) > 0 )
     {
         MP4SetMetadataGenre(mp4file, FileTag->genre);
     }else
     {
-        MP4DeleteMetadataGenre(mp4file);
+        //MP4DeleteMetadataGenre(mp4file);
+        MP4SetMetadataGenre(mp4file, "");
     }
 
     /***********
@@ -365,7 +372,8 @@
         MP4SetMetadataComment(mp4file, FileTag->comment);
     }else
     {
-        MP4DeleteMetadataComment(mp4file);
+        //MP4DeleteMetadataComment(mp4file);
+        MP4SetMetadataComment(mp4file, "");
     }
 
     /**********************
@@ -376,7 +384,8 @@
         MP4SetMetadataWriter(mp4file, FileTag->composer);
     }else
     {
-        MP4DeleteMetadataWriter(mp4file);
+        //MP4DeleteMetadataWriter(mp4file);
+        MP4SetMetadataWriter(mp4file, "");
     }
 
     /*****************
@@ -387,7 +396,8 @@
         MP4SetMetadataTool(mp4file, FileTag->encoded_by);
     }else
     {
-        MP4DeleteMetadataTool(mp4file);
+        //MP4DeleteMetadataTool(mp4file);
+        MP4SetMetadataTool(mp4file, "");
     }
 
     /***********
@@ -396,12 +406,13 @@
     {
         Picture *pic;
         
-        MP4DeleteMetadataCoverArt( mp4file );
+        //MP4DeleteMetadataCoverArt( mp4file );
+        MP4SetMetadataCoverArt(mp4file, NULL, 0);
         for( pic = FileTag->picture; pic; pic = pic->next )
         {
             if( pic->type == PICTURE_TYPE_FRONT_COVER )
             {
-                MP4SetMetadataCoverArt( mp4file, pic->data, pic->size );
+                MP4SetMetadataCoverArt(mp4file, pic->data, pic->size);
             }
         }
     }