Re: [Easytag-mailing] Can't save default preferences without XMMS installed

[Jérôme COUDERC <easytag gmail com>]

Indeed, in your case, you must clear this field to be able to save the 
preferences.
In my current version, now we test if the program exists before to 
display it in the preferences window...

Also, the old option "Save the configuration before exiting the program" 
was removed as it have no sense now!

There is some changes to do before to have an "apply" and "save" buttons 
working as in the Gnome Human Interface Guidelines, but I prefer to keep 
the two buttons.
As we should have this behaviour:
   - apply : apply a change in the window (and don't close it)
   - if user click "cancel" : we lost the settings "applied" and close 
the window
   - if user click "save" : save the changes and close the window

Regards,
Jerome




Daniel Drake wrote, the 11.11.2005 13:09 :

> Hi,
>
> I don't have xmms installed on this system, and when I open the 
> preferences window, clicking "Save" and "Apply" does nothing (not even 
> close the preferences window).
>
> This is because the Check_FilePlayerCombo() check is failing as I do 
> not have xmms available on this system.
>
> It's not right for easytag to silently fail here - there should at 
> least be a message dialog saying why preferences can't be saved (also 
> for the other Check_ checks).
>
> I think the file player check is bogus though, e.g. XMMS may be 
> installed when the user saves the preferences but unavailable when 
> they try and play an audio file in the future. I think the preferences 
> window should accept any-value, and the existence of the player should 
> only be checked when the user tries to play an audio file (in which 
> case a friendly explanatory dialog appears explaining that the player 
> could not be found).
>
> Also, I agree with the recent thread the easytag is getting too 
> complicated. While we're on the subject of preferences, I think the 
> "Save" and "Apply" buttons should be merged into one (just "Apply"), 
> which saves the config changes immediately. The "Save the 
> configuration before exiting the program" option should also be 
> removed. The functionality of being able to make a config change which 
> is forgotten on shutdown isn't very useful...
>
> Daniel
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. 
> Download
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> Easytag-mailing mailing list
> Easytag-mailing lists sourceforge net
> https://lists.sourceforge.net/lists/listinfo/easytag-mailing

--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <easytag gmail com>