Re: Group resizing isses (was: crash with my patch...)

[George Georgalis <george galis org>]

On Tue, Sep 30, 2014 at 10:34 PM, George Georgalis <george galis org> wrote:

On Fri, Sep 26, 2014 at 12:20 PM, Hans Breuer <hans breuer org> wrote:

Am 23.09.2014 um 05:44 schrieb George Georgalis:

I've been happy with my patch to increase size of object handles and
connection points. However, I discovered if I group two objects then grab a
resize handle, the grouping disappears. If I then select all and zoom to
fit, crash.

Probaly two issues:
 - the Group::move_hande() was seriously flawed (transformation is one
   of the new features after 0.97.x). I've just pushed a better
   implementation to master [1]

transformation sounds like the key term. before objects would disappear, they would extend on side oppisit the handles being adjusted....

I had checked before/after my patch, so do think it brought out the issue, at least. Maybe from using different coordinate math for draw_pixel_line vs draw_pixel_rect? In any event, all seems resolved in the origin/master from today.

Hi Hans,

I've not had any additional group resize problems. The build from today seems just fine too, my patched build script is attached.

I imagine variable re-size handles could be complex to integrate into preferences, but everyone I've shared my handles/connection point size increase patch with, has been very receptive. The size of these items does have a real useability impact. Bigger connection points can clutter, but I just un-enable them in the view menu when I'm not using them. Turns out, not much toggle is required for most drawings. (but a kbd-shortcut would be handy).

So, maybe there is a solution? An easier way to integrate the feature into preferences for release versions might be through a toggle vs variable option. Would you be open to adding a small, medium, large handle size option in preferences? If so, I would be willing to write some pseudo code to add the option. Interested?

-George

 

Thanks!

-George

 

--
George Georgalis, (415) 894-2710, http://www.galis.org/

--

George Georgalis, (415) 894-2710, http://www.galis.org/

Attachment: dia-inst.sh
Description: Bourne shell script