Re: How to consistently handle custom shapes line_width?

["loli" <loli unsa edu ar>]

On Tue, 22 Jul 2008 23:01:04 +0200, Hans Breuer wrote
> While creating my own custom shapes and improving the documentation 
> of custom-shapes [1] I noticed that the "stroke-width" given by the 
> shape file is not consistently handled. Only the very first line-
> width used during shape drawing was replaced by the one given in the 
> shapes property. Further strokes were drawn with the product of 
> stroke-width from the shape file and the "border_width" 
> (line-width) given by the properties. Apparently this is broken 
> since the beginning of time. It only seemed to work when in the 
> drawing sequence there was just one "stroke".
>
> I see three options:
>
>   * always use the stroke-width given by the shape-file
>   * always use the line_width given by the properties dialog
>   * something in between ;)
>
> The last option seems most usefull but needs some further definition.
> I currently have implmented a version where every line-width gets 
> weighted by the ratio ("border_width" / "first-stroke-width-in-file")
> . It should give the same result for single-stroke-shapes as before 
> (e.g. apparently all of Assorted [2]), but will produce artifacts 
> for shapes adding a workaround like "Cisco - PC".
>
> Of course it would also be possible to accept and document the 
> current workaround apparently added to a lot of shapes. But IMO this 
> would be the least compelling approach.
>
> Comments?

Two questions:
1) For each possible shape there seems to be two different property dialogs:
the one obtained by double clicking on the drawn shape in canvas and the one
labeled "predetermined....". the last one never offered anything about lines
2) How do you choose the border line? Is it by double clicking on one of the
parallel small vertical lines at the right of main menu?

> BTW: if you want to test it yourself apply the attached patch.
>
> Thanks,
>       Hans
>
> [1] http://svn.gnome.org/viewvc/dia/trunk/doc/custom-shapes?view=log
> [2] http://bugzilla.gnome.org/show_bug.cgi?id=120784
>
> -------- Hans "at" Breuer "dot" Org -----------
> Tell me what you need, and I'll tell you how to
> get along without it.                -- Dilbert


--  
Loli 
loli unsa edu ar