Re: Patch for Delete key behavior (for dia-0.96.1)

[Hans Breuer <hans breuer org>]

On 22.09.2007 00:42, Ondrej Mikle wrote:
> Hello.
>
> I send a patch for the Delete key behavior in Dia. It is remapped to
> Ctrl+Delete (or remap it some other suitable shortcut), since a lot of
> people find it annoying that pressing Delete while editing text deletes
> the object.
>
> It seems that different person chose Delete key for menu and other
> person wrote the text_key_event (lib/text.c:795) -- if Delete is not
> grabbed by menu, pressing Delete while editing text behaves as one would
> expect.
Indeed differnt people have tried to fix this problem ;) In Dia's stone age
 deleting objects was bound to Ctrl+D for exactly this reason. Than the
more natural Delete key was used giving us the described regression.
But falling back to some other 'random' hotkey for deleting objects is not
the right solution, just a workaround.

The real fix would be some managment of text edit mode, where all the
usuful keys (not only Delete but also cursor keys, Home, End) are bound to
text editing as one is used by other programs.

This extra mode - maybe shown and selectable by a cursor button in the
toolbox - would allow us to distinguish between object editing, where these
keys are used for diagram modification.

> Also, menus_init() (at app/menus.c:465, where ~/.dia/menurc shortcuts
> are set up) is called before menus_initialize_updatable_items
> (app/menus.c:768), which makes Dia ditch all user-chosen settings in the
> menurc file.
A patch to fix the broken user editable shortcuts should give you the same
workaround but not break the use of Delete for diagram editing for other
users. It would have a much bigger chance for inclusion.

> Those are just minor nuisances, but fixing the delete key behavior makes
> working with Dia much more comfortable.
Although I'm sometimes bitten by deleting the whole object although I only
wanted to edit text for me deleting objects via Ctrl+Delete wouldt take
away more comfort than making the small text editing improvement.

Regards,
        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert