Re: tabbed interface

["Patrick Hallinan" <patrick j hallinan gmail com>]

On 5/20/07, Lars Clausen <lars raeder dk> wrote:

On Wed, 2007-05-16 at 06:56 -0500, Patrick Hallinan wrote:
> On 5/5/07, Lars Clausen <lars raeder dk> wrote:
>         On Sat, 2007-04-28 at 01:48 -0500, Patrick Hallinan wrote:
[snip]

I can't apply the patch at the moment -- it crashes for me when applied
to the normal SVN under Ubuntu Dapper x86:

I'll get Ubuntu Dapper installed so I can see what's happening.

#0  0xb7ddbc91 in gtk_widget_show () from /usr/lib/libgtk-x11-2.0.so.0
#1  0x08079c21 in create_display_shell (ddisp=0x97b2b28, width=500,
    height=400, title=0x96c7f49 "Diagram1.dia", use_mbar=0,
top_level_window=1)
    at interface.c:671
#2  0x0807281f in initialize_display_widgets (ddisp=0x97b2b28) at
display.c:211
#3  0x08072ad9 in new_display (dia=0x80ec120) at display.c:343
#4  0x0806b879 in file_new_callback (action="" at commands.c:136
#5  0x0806e1e1 in app_init (argc=1, argv=0xbfdb8464) at app_procs.c:956
#6  0x0809f41e in main (argc=0, argv=0x0) at main.c:26

Doesn't crash w/o integrated UI set, and it doesn't matter if the
menubar is set to on or off.

For code cleanup, I think a great amount of improvement can be had by
abstracting out where the various widgets live in the two UI states, so
you can use the same code to access them.

The first thing  I was going to do was to fix the toolbar to use the UI Manager instead of my cobbled in code. 

I think the first thing that would need to change architecturally is to make a separation between the Dia Editor and the display shell.  I have been thinking about that but I don't know how to do it.  I'm still very much assimilating how things are organized and I am relatively new to gtk.  Also, I've wondered if there is a Dia-View where you can see the diagrams but not edit them?  I haven't looked at dia-embedded stuff but I wondered if that was what that was about.

Pat.