Re: Reminder: action required when updating dependencies or build options

On Wed, Jan 13, 2021 at 9:28 pm, Philip Withnall <philip tecnocode co uk> wrote:
Given that you’ve just committed to submitting MRs and waiting for CI
to pass, rather than pushing directly to master, perhaps this rule
should be rethought?

Hm... as long as we have permission to merge the MR after CI has passed, or to bypass the CI if it's broken due to a preexisting issue, then we should be good. However, I'm not sure GitLab allows this? E.g. we discovered yesterday that I didn't have permission to commit to gnome-remote-desktop until Jonas played with the settings; there, I had created a MR, but only project maintainers were able to merge it.

The worst-case scenario would be: need to revert a commit, CI is already broken due to some preexisting unrelated issue that we don't know how to fix, can't land revert via MR because it requires CI to pass, can't change the setting to allow bypassing CI because the only way to get permission to change the setting is to update the doap, can't update the doap without first passing CI....

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]