Re: NotificationSource GnomeGoal

[Giovanni Campagna <scampa giovanni gmail com>]

2012/12/21 Sriram Ramkrishna <sri ramkrishna me>:
>
>
>
> On Thu, Dec 20, 2012 at 3:30 PM, Giovanni Campagna
> <scampa giovanni gmail com> wrote:
>>
>>
>> On the other hand, the interesting part here is static application
>> registration. Lacking any better idea, this is implemented by looking
>> at the desktop file for a boolean key called
>> "X-GNOME-UsesNotifications".
>> Therefore, I updated the GnomeGoal mentioned in the subject ([1]). If
>> you develop an application that uses libnotify, please add
>> X-GNOME-UsesNotifications to the desktop file.
>>
>
> I assume this feature is really about implementing this:
> https://live.gnome.org/Design/SystemSettings/Notifications
>
> Is that right?

That, and https://live.gnome.org/ThreePointSeven/Features/NotificationFiltering.
The GnomeGoal is just what applications need to do to cooperate best
with the control-center and the shell.

>>
>> At the same time, you need to make sure that the application is
>> correctly associated with its stored policy. As I said above, for
>> regular apps this requires no changes. By regular I mean: sending
>> notifications from the same process, having a desktop file that is
>> tracked via WM_CLASS by the shell and having at least one visible
>> window when the notification is send. If any of those conditions may
>> not be satisfied, you must set the 'desktop-entry' hint to the
>> basename of you desktop file, without the final '.desktop'.
>>
>
> I'm not sure I understand this instruction..  Is this in the code or
> somewhere else?

The GnomeGoal page explains that one needs to call
notify_notification_set_hint_string(n, "desktop-entry", desktop_id)
before notify_notification_show(). This is good practice in all cases,
so if you want, ignore that part of my mail and add the code.
I just wanted to highlight that we try our best to work with
uncooperative applications, in certain (hopefully common) cases, no
code changes are needed to get filtering.

>>
>> Hope you are not too angry with me for the new work, and enjoy the new
>> feature!
>
>
> This is great!  However, I do have a question.  Why does the link:
> https://live.gnome.org/GnomeGoals/NotificationSource
>
> have this message:
>
> This is only a proposal at this time, and not approved for project-wide
> application.
> This should not be applied before being officially turned into a GNOME Goal!
>
>
> in a red banner?  I assume that it is in fact an approved GNOME Goal? :-)
> Just wondering..

That's part of the GnomeGoal template, every goal starts with that
banner. It's up to the release team to elevate goals from proposals to
requirements, but usually implementations starts way before approval.

Giovanni